securing / SCSVS

Smart Contract Security Verification Standard
623 stars 88 forks source link

Regarding SCP 7.10 #19

Open htadashi opened 2 years ago

htadashi commented 2 years ago
# Description
7.10 Verify that the external keyword is used for functions that can be called externally only to save gas.

Only changing to external will not save gas. The arguments parameters also must be changed from memory to calldata: https://ethereum.stackexchange.com/a/107939/4630

damianrusinek commented 2 years ago

Thanks for the link, we will have a look on that.