Searchbox broken in example when using ace-builds@1.20.0 and >

[FirstWhack]

Problem

When using ace-builds 1.20 and above with latest version of react-ace the searchbox extension does not work. Error with unminified says nls is not defined.

Cause: https://github.com/ajaxorg/ace/pull/5153 This contribution to Ace introduced a dependency on a new method nls to provide translations however the method is not always present and no checks are done to ensure it is. I am unable to locate any related documentation to clarify further.

Sample code to reproduce your issue

• Run example with ace-builds@1.20.0 or greater
• Ctrl+F/Cmd+F to search
• Observe errors thrown in console

References

https://github.com/ajaxorg/ace/pull/5153

Progress on: #

[zerocewl]

Same issue here: ace-builds@1.19.0 is working fine, but 1.20.0 throws an error in the console:

ext-searchbox.js?5445:1 Uncaught TypeError: f is not a function
    at new e (ext-searchbox.js?5445:1:4514)
    at t.Search (ext-searchbox.js?5445:1:12802)
    at eval (ace.js?00a6:11045:67)
    at exports.loadModule (ace.js?00a6:1154:1)
    at Object.exec (ace.js?00a6:11045:1)
    at eval (ace.js?00a6:10797:1)
    at EventEmitter._emit.EventEmitter._dispatchEvent (ace.js?00a6:855:1)
    at CommandManager.exec (ace.js?00a6:10822:1)
    at KeyBinding.$callKeyboardHandlers (ace.js?00a6:4018:1)
    at KeyBinding.onCommandKey (ace.js?00a6:4037:1)

[zerocewl]

Should be fixed according to https://github.com/ajaxorg/ace/issues/5303. The search function works in the suggested ace kitchen-sink too.

Take care of removing all old ace-builds versions from the lock file e.g. removing and readding the related (react) ace packages.

Tested version which works for me: react-ace@1.10.0 and ace-builds@1.32.5