securingsincity / react-ace

React Ace Component

http://securingsincity.github.io/react-ace/

MIT License

4.02k stars 603 forks source link

ace-builds bumped from 1.4.14 to 1.23.1 #1833

Closed arkadius closed 5 months ago

arkadius commented 1 year ago

What's in this PR?

PR bumps ace-builds from 1.4.14 to 1.23.1.

List the changes you made and your reasons for them.

Due to changes in Ace.VirtualRenderer API, it was necessary to make IRenderer.scroller mandatory.

Also because of the fact that ace.edit returns Ace.Editor which doesn't contain scroller, it was necessary to downcast it in one place into IAceEditor

References

Fixes #1547

securingsincity commented 5 months ago

Fixed in 11.0.0 with every dep thanks @arkadius