securingsincity / react-ace

React Ace Component

http://securingsincity.github.io/react-ace/

MIT License

4.01k stars 603 forks source link

`this.editor` null check #1884

Closed sandragg closed 3 weeks ago

sandragg commented 2 months ago

What's in this PR?

I ran into a bug where the onChange handler is attempted to be called on the unmounted element (because of the debounced onChange method). Thus, it throws Cannot read properties of null (reading 'getValue').

List the changes you made and your reasons for them.

Make sure any changes to code include changes to documentation.

References

Fixes

Progress on:

sandragg commented 2 months ago

@securingsincity I would appreciate a review on this

jusstes commented 2 months ago

I got the same bug. @securingsincity can you look at this PR?