search

securingsincity / react-ace

React Ace Component
http://securingsincity.github.io/react-ace/
MIT License
4.01k stars 603 forks source link

Update types.ts to match ace-builds #1898

Closed gchallen closed 3 weeks ago

gchallen commented 2 months ago

ace-builds defines scroller as an HTMLElement. This change avoids type errors when using IAceEditor as the type of the editor reference returned from onLoad.

What's in this PR?

A small change to the react-ace typings.

List the changes you made and your reasons for them.

To match ace-builds, specifically the scroller element defined here: https://github.com/ajaxorg/ace-builds/blob/master/ace.d.ts#L683.