security-force-monitor / sfm-cms

Platform for sharing complex information about security forces. Powers WhoWasInCommand.com
https://whowasincommand.com
10 stars 3 forks source link

[importer] disable check on country attribute in incident model #827

Open tlongers opened 10 months ago

tlongers commented 10 months ago

Where a value in incident:location has no match in the locations dataset, the importer reports two errors:

Code:

https://github.com/security-force-monitor/sfm-cms/blob/c8a00b435ac57732d767617c28eef264aed9f9d4/sfm_pc/management/commands/import_country_data.py#L2168-L2173

The data sheet does not contain an incident:country attribute to check, so the report is misleading. Unless it does something else that I can't see, I suggest removing this check.

hancush commented 10 months ago

Makes sense.