search

security-union / videocall-rs

teleconference system written in rust
MIT License
1.34k stars 114 forks source link

Move `VideoCallClient` into its own crate #142

Closed ronen closed 8 months ago

ronen commented 10 months ago

This is a continuation of #137. It's the same code, but takes it to the next step: Crate-ified the VideoCallClient stuff: Moved all the code from yew-ui/src/model into a new top-level workspace & crate videocall-client. And added documentation! And of course also conformed yew-ui to use the new crate.

For ease of seeing what's going on here, I've based this PR off the client branch. Dunno whether you'd want to merge this onto that branch for merging as part of #137, or I can change this to be based off main and merging this would supercede #137, or wait until #137 is merged on its own then I can rebase all this off of main and update this PR. I have no strong opinions. But it's done and working so figured I'd put it out for eyeballs now :)

darioalessandro commented 10 months ago

Ok, I'll take a look, thanks for this huge contribution @ronen !!

darioalessandro commented 10 months ago

@ronen @griffobeid I think that you guys should talk about https://github.com/security-union/videocall-rs/pull/144