search

security-union / videocall-rs

teleconference system written in rust
https://www.videocall.rs
MIT License
1.41k stars 124 forks source link

Aspect ratio of peer's video is wrong #32

Open darioalessandro opened 1 year ago

darioalessandro commented 1 year ago

The aspect ratio is hardcoded.

Instead, the code should lazily adapt to the aspect ratio of the decoded images.

Screen Shot 2023-05-20 at 12 34 40 PM
vitorsgoncalves commented 1 year ago

Hello. I came across your post on reddit, and I'd like to contribute. I believe this issue can be a good stating point, right?

darioalessandro commented 1 year ago

yes!! thank you so much for reaching out brother!!

darioalessandro commented 1 year ago

@vitorsgoncalves the main issue is that the encoder's resolution is hardcoded, we do not even look at the aspect ratio that the device has: https://github.com/security-union/zoom-rs/blob/9a551e33412ab9169273dddbeecd9978a3713d20/yew-ui/src/components/host.rs#L425-L426

darioalessandro commented 1 year ago

@vitorsgoncalves are you planning to take on this feature?

vitorsgoncalves commented 1 year ago

Yes. I'm needing to learn a few things first, so I'm taking longer than expected.

vitorsgoncalves commented 1 year ago

I'm sorry, but I won't have much time to work on this from now on, and still didn't make much progress. I think it's better to let you assign someone else.

darioalessandro commented 1 year ago

Ok no worries, care to share what you tried?