search

security-union / videocall-rs

teleconference system written in rust
https://www.videocall.rs
MIT License
1.36k stars 117 forks source link

Create Lightweight Docker Image #68

Closed ImBIOS closed 1 year ago

ImBIOS commented 1 year ago

Is your feature request related to a problem? Please describe. The current docker image built by Dockerfile.actix and Dockerfile.yew is huge because we use it for the active development process as runtime inside docker-compose.yml, it's not 'old device' friendly tho.

Describe the solution you'd like We can create separated those Dockerfile and docker-compose.yml for development and production.

Describe alternatives you've considered undefined

Additional context https://levelup.gitconnected.com/create-an-optimized-rust-alpine-docker-image-1940db638a6c https://dev.to/mohammadfaisal/how-i-reduced-docker-image-size-from-143-gb-to-224-mb-53nc

griffobeid commented 1 year ago

Great idea! Do you want to take on this task @ImBIOS ?

darioalessandro commented 1 year ago

They did!! https://github.com/security-union/zoom-rs/pull/69

griffobeid commented 1 year ago

Nice, some great improvements in #69, @ImBIOS do you want to add multistage builds as well? I think that would be best for a production env like gcloud where the VMs default to 10GB disks

ImBIOS commented 1 year ago

@griffobeid @darioalessandro Let me try to take this task more seriously, please assign me here.

darioalessandro commented 1 year ago

hahahah you got it @ImBIOS thank you so much for your contributions!!

griffobeid commented 1 year ago

This may give you trouble with the yew-ui image minification: https://github.com/security-union/zoom-rs/issues/72