security-union / videocall-rs

teleconference system written in rust
https://www.videocall.rs
MIT License
1.36k stars 117 forks source link

Factor out CameraEncoder, MicrophoneEncoder, and ScreenEncoder #90

Closed ronen closed 1 year ago

ronen commented 1 year ago

[Another step towards #74]

Factored out CameraEncoder, MicrophoneEncoder, and ScreenEncoder

The only structural change is that previously there was a single bit destroy: Arc<AtomicBool> that would stop all encoding when it was set, but now each Encoder has its own. Previously the host.destroy() method would set that bit, but now it calls a .stop() method for each encoder.

Also:

griffobeid commented 1 year ago

Thanks for the contribution @ronen

I tested it out locally and it looks good to me! @darioalessandro can you take a look?

darioalessandro commented 1 year ago

Wow !!! this is great!! I love how you moved all the model out of the host!!

looking now

darioalessandro commented 1 year ago

I am sorry for taking this long! will review again by eod tomorrow July 9

ronen commented 1 year ago

I am sorry for taking this long! will review again by eod tomorrow July 9

July 9, but luckily you didn't specify a year :)

Just joking around, no rush.

darioalessandro commented 1 year ago

I am sorry for taking this long! will review again by eod tomorrow July 9

July 9, but luckily you didn't specify a year :)

Just joking around, no rush.

XD XD sorry mate, I am on it right now