security-union / videocall-rs

teleconference system written in rust
https://www.videocall.rs
MIT License
1.36k stars 117 forks source link

Factor out decoder manager #96

Closed ronen closed 1 year ago

ronen commented 1 year ago

[Another step towards #74]

Created a PeerDecoderManager (I'm open to a better name!) that handles keeping track of the currently connected peers, dispatching each packet to the appropriate decoder, etc. factored all that out of Attendants.

It provides some callbacks that are set by Attendants:

In the future, could add on_last_frame((key, media_type)) and on_peer_removed(key)) to handle a peer stopping audio, video or screen share or a peer disconnecting entirely, if/when there's protocol to detect those.

darioalessandro commented 1 year ago

@ronen we mentioned in our reddit announcement, I hope that is ok with you: https://www.reddit.com/r/rust/comments/14vwxfh/we_just_released_our_rust_webtransport/?utm_source=share&utm_medium=web2x&context=3

Thanks for helping us to shape up a proper architecture!!

ronen commented 1 year ago

@ronen we mentioned in our reddit announcement, I hope that is ok with you:

That's fine, thanks for the shout out.

More to come...

darioalessandro commented 1 year ago

still looking at this, sorry for the delay!

darioalessandro commented 1 year ago

Code looks good, I'll just test tonight to make sure that everything still works