The python Emission Localization and Quantification (pyELQ) code aims to maximize effective use of existing measurement data, especially from continuous monitoring solutions. The code has been developed to detect, localize, and quantify methane emissions from concentration and wind measurements.
source_model.py:
Threshold function has been changed to a property of the source model as a lambda function, and it can be passed on by the user. The default of the threshold function has been changed from np.max(x) to np.quantile(x, 0.95)
gaussian_plume.compute_coverage:
compute coverage input parameter is changed to remove the default (which was set to np.max) as now it uses the threshold_function passed on from the source_model
Fixes # (issue)
Type of change
Please delete options that are not relevant.
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update
Jupyter Notebooks
No changes to Jupyter notebooks.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
The available test function for source_model and gaussian_plume are passed with this change.
There is no need to add a new test.
Checklist:
[ x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
Description
source_model.py: Threshold function has been changed to a property of the source model as a lambda function, and it can be passed on by the user. The default of the threshold function has been changed from np.max(x) to np.quantile(x, 0.95)
gaussian_plume.compute_coverage: compute coverage input parameter is changed to remove the default (which was set to np.max) as now it uses the threshold_function passed on from the source_model
Fixes # (issue)
Type of change
Please delete options that are not relevant.
Jupyter Notebooks
No changes to Jupyter notebooks.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
The available test function for source_model and gaussian_plume are passed with this change. There is no need to add a new test.
Checklist: