search

sede-open / synthoseis

Generating seismic data and associated labels to train deep learning networks.
MIT License
54 stars 10 forks source link

closures.write_closure_info_to_log(seismic.rfc_raw[1:4, ...]) #22

Open klaas-koster opened 3 months ago

klaas-koster commented 3 months ago

The call in main.py to write_closure_info_to_log() is hardwired to pass on the second, third, and fourth angle. That looks like a remnant from the past where the code assumed the user always specified three angles in the configuration file and the code padded those with a 0- and 45-degree response. I suggest changing

closures.write_closure_info_to_log(seismic.rfc_raw[1:4, ...])

to

closures.write_closure_info_to_log(seismic.rfc_raw[:, ...])

Note, that this is not guaranteed to give good results if the user specifies just one angle in the configuration file.

I am now seeing that I sometimes still get 5 angles in rfc_raw when I specify 3 in the configuration file. In that case my fix above does not work because the code is now trying to match 5 RFCs with 3 angles.

I need to figure out why I sometimes get 3 and other times 5 angles in rfc_raw...

gavargas22 commented 2 months ago

Thank you for all your great analysis of the repo. These are great ideas

geokefe commented 2 months ago

I'm having problem with the installation; how do we install synthoseis in Jupiter notebook?

klaas-koster commented 2 months ago

@geokefe this is not the right place to ask that question. Anyway, there is a 'notebook' folder that show exactly how to use synthoseis in a Jupyter notebook.

gavargas22 commented 2 months ago

I'm having problem with the installation; how do we install synthoseis in Jupiter notebook?

Indeed, you can submit a new issue for any question you have so we can keep track of it in a separate ticket.

I will make a new issue to discuss an answer to your question