sedenion / OpenModMan

Open Mod Manager - Open source and generic Mod ("Modifications") manager.
GNU General Public License v3.0
84 stars 5 forks source link

Getting unexplained Mod download error following update to 1.2.1 #57

Closed hbjonsson closed 6 months ago

hbjonsson commented 6 months ago

Following the update to 1.2.1 I´mg etting unexplained Mod download errors from repositories that were working before.

Have done a reinstall to no avail. The message offers no insight as to why it failed and the debug log shows nothing.

image

The repository validates ok - running as admin has no effect. Zero byte files get added to the /Library folder and the download appears failed. Any idea on further debugging/troubleshooting?

sedenion commented 6 months ago

please give repository address/coordinates and name of the mod so I can test myself and investigate.

hbjonsson commented 6 months ago

@sedenion Here is the link - any one of the mods will fail.

https://cloud.455aew.com/apps/sharingpath/public/repo/455_savegames_repo.omx

sedenion commented 6 months ago

Ok, it's because Open Mod Manager does not encode special characters of the URL (like space to %20 for example) and it never did. And the fact is that Mods names in your repository contains spaces.

Internally I corrected error dialog so it give some clue about what failed and added a rudimentary URL encoding routine. On your side, until I release a new version, I suggest you change Mod names, replacing spaces by underscores "_", or adding custom download URL for each Mod of your repository, replacing spaces by "%20"

hbjonsson commented 6 months ago

Thanks,. I´ll try custom download URL. I fixed the repo and mod names/paths to not have any spaces and am still getting the same errors, in case you want to look again.

hbjonsson commented 6 months ago

@sedenion Can confirm that the custom url works. Without the custom url, OMM seems to inject the name of the repo file itself into the path.