search

sedge / opendojo

An open-source student and class management system for traditional karate clubs
Mozilla Public License 2.0
2 stars 0 forks source link

Remove unused buttons in rank sequence editing #160

Open sedge opened 9 years ago

sedge commented 9 years ago

Before edit has been clicked, the other buttons shouldn't exist:

screen shot 2015-04-17 at 5 40 59 pm

After it has been clicked, it should disappear instead of hanging around:

screen shot 2015-04-17 at 5 41 31 pm

Plumpernickel commented 9 years ago

@AlinaShtramwasser, what are your thoughts on this? I like the disabled switch happening there. It aesthetically pleases me. Unless this was specifically requested to be removed by Mike or Emile, I'd like your input to tiebreak this.

sedge commented 9 years ago

If it doesn't make the usage clearer then it shouldn't be there. Less is more - my two cents.

sedge commented 9 years ago

As proof of "less is more cuz it tends to cause fewer issues", I present this view zoomed in a little:

screen shot 2015-04-24 at 2 07 55 pm

AlinaShtramwasser commented 9 years ago

Hi guys sorry am a bit late I thought the disabled switch was nice -- what does Mike think? On Apr 25, 2015 4:08 AM, "Kieran Sedgwick" notifications@github.com wrote:

As proof of "less is more cuz it tends to cause fewer issues", I present this view zoomed in a little:

[image: screen shot 2015-04-24 at 2 07 55 pm] https://cloud.githubusercontent.com/assets/1616860/7325299/6646f9de-ea8b-11e4-877e-f93daf5aa6b6.png

— Reply to this email directly or view it on GitHub https://github.com/sedge/opendojo/issues/160#issuecomment-96017770.