search

sedos-project / data_adapter

Provides general functionality for other data adapters
GNU Affero General Public License v3.0
0 stars 0 forks source link

Enchancement: Flexible Merge groups #17

Closed FelixMau closed 7 months ago

FelixMau commented 1 year ago

https://github.com/sedos-project/data_adapter/blob/9dcac10cfb605852bc22951bd3ce1626545addff/data_adapter/preprocessing.py#L14-L20

Data can not be processed if the dataset does not contain the default MERGE_GROUPS. Maybe we could add a check, whether the required MERGE_GROUP data is included in the Dataset and and/or reduce the grouping according to the passed Data. For example if no year (for scalars) is passed merging would only take place by regions and we could give a warning?

Should we include minimal required input data in docs?

henhuy commented 1 year ago

For simplicity reasons, I would rather raise an error if one of those columns is not present in data table..