sedos-project / data_adapter_oemof

This respository holds the data adapters to connect oemof with the OEDatamodel-concrete.
GNU Affero General Public License v3.0
0 stars 1 forks source link

Match scalars and timeseries columns #30

Closed FelixMau closed 1 year ago

FelixMau commented 1 year ago

There has to be additional functionality to write correct time series names in columns for time series. The current situation is like this:

Although using a similar method, the result is different as different datasets/columns are referenced. This must somehow be unified:

There might be cases where more time series are allowed in the facade as there are provided time series.

Further: process_data.scalar has a row for each region and year, the refactored time series only have one column for each region and all years. This is not a big problem, but needs to be addressed at some point when it will be integrated into tabular.

FelixMau commented 1 year ago

In 0baca0e76669efafd004e850ef8a511594f32ffc I added "year" to scalars. The region is inherently mapped by the profile column since each region should have its own profile. However, I can imagine a scenario where future users may only want scalar data to vary across regions.

FelixMau commented 1 year ago

Timeseries are currently only matched if field type is matching as a Series and if the Series entries are all found within timeseries columns. This approach assures to only write foreign keys for timeseries if there are Series connected to the Dataset with matching naming.

Timeseries are exploded within data_adapter therefore this issue is outdated and the period csv writing will be tackled in #44