sedos-project / data_adapter_oemof

This respository holds the data adapters to connect oemof with the OEDatamodel-concrete.
GNU Affero General Public License v3.0
0 stars 1 forks source link

Fix and extend tests #48

Closed FelixMau closed 10 months ago

FelixMau commented 10 months ago

Closes #43

Please note that two test cannot be completed yet since they depend on changes from other branches and modules.

FelixMau commented 10 months ago

It seems that tests are failing in data_adapter for unsupported operand On my machine the tests run without errors. I'd be glad for feedback on what to do here.

nailend commented 10 months ago

I also don't understand what is happening. The tests fail for python 3.8 and 3.10 for different reasons. I tried to fix the environment variable thing but dont know if I just disimproved it... @henhuy can u have a look?

nailend commented 10 months ago

@FelixMau can you please check on the missing csvfiles in test_build_datapackage?

The list of ~300 mapping-warnings is impressive. Maybe we should specify these, with information about the process name to make them more usefull?

FelixMau commented 10 months ago

@FelixMau can you please check on the csvfiles in test_build_datapackage?

Do you mean because of missing period merging? I think we have to decide on how the inputs should look like first (in #45)

The list of ~300 mapping-warnings is impressive.

Yes indeed impressive and less usefull, will have a look into that!

nailend commented 10 months ago

Do you mean because of missing period merging? I think we have to decide on how the inputs should look like first (in #45)

https://github.com/sedos-project/data_adapter_oemof/actions/runs/5888510361/job/15969855183?pr=48#step:9:538

Because of the missing csv

FelixMau commented 10 months ago