Closed FelixMau closed 7 months ago
This is interesting, as I assumed we would have to do the calculations in the facade, but I like this approach much better!
IMO we should not blow up functionality of the mapper.
And also, we already have calculations covered in the Adapter
class, where we have full python support - writing functions and keys in JSON or any other format gets ugly real quick.
Regarding access to other processes (like WACC)- we must be implement this anyway and this is not covered by code from above.
When calculations have to be made it might be neccesary to declare input variables.
For example efficiency might be calculated from "inflow_efficiency" and "ourflow_efficiency". Therefore I would like to change the Parameter mapping. This might also be helpful to find wacc or other 'outside process' varaibles I think.
The resulting Map would look something like this:
@henhuy @nailend Please let me know your thoughts on that. I think I would change how the parameter mapper is interpreted in Mapper get method.