sedos-project / data_adapter_oemof

This respository holds the data adapters to connect oemof with the OEDatamodel-concrete.
GNU Affero General Public License v3.0
0 stars 1 forks source link

Extend Mappers, fix bugs #59

Closed FelixMau closed 5 months ago

FelixMau commented 7 months ago

Datapackage can be created succesfully.

Goal here is to modify the Mappers to create a datapackage where a Model can be created from for the Hack-a-thon test data.

FelixMau commented 7 months ago

Energysystem model building left for check from tabular deseralization expert @nailend I run into an error while creating "timeincrements"

Edit: I did not notice I should name the increment on periods csv "increment" instead of "timeincrement"

nailend commented 7 months ago

Edit: I did not notice I should name the increment on periods csv "increment" instead of "timeincrement"

No it should actually be timeincrement @FelixMau

henhuy commented 6 months ago

Looks promising! - last thing would be to fix demand sequence.

FelixMau commented 6 months ago

@nailend For some reason when initializing the datapackage reading does not recognize storage lifetimes correctly and does not add it to storage flows.

@henhuy The pytest somehow does not fail locally but here witth an error in data_adapter:

Process
    inputs: list[str] | None = None
E   TypeError: unsupported operand type(s) for |: 'types.GenericAlias' and 'NoneType'
henhuy commented 6 months ago

@henhuy The pytest somehow does not fail locally but here witth an error in data_adapter:

Process
    inputs: list[str] | None = None
E   TypeError: unsupported operand type(s) for |: 'types.GenericAlias' and 'NoneType'

Ah shit - this works only in newer python versions, see https://peps.python.org/pep-0604/ We could either skip support for python 3.9 or I have to fix it in data_adapter

FelixMau commented 6 months ago

I think we can easily skip Python 3.9? I will upgrade to 3.10.

I would also like to skip fixing the reading of datapackage here since it seems to be a bigger issue about some data not being read in properly.