sedrubal / brother_printer_fwupd

Script to update the firmware of some Brother printers
https://pypi.org/project/brother_printer_fwupd/
GNU General Public License v3.0
30 stars 5 forks source link

Support for ADS-4700W #12

Closed darix closed 9 months ago

darix commented 1 year ago
  1. it has a fun line in the snmpwalk output:
SNMPv2-SMI::enterprises.2435.2.4.3.99.3.1.6.1.2.11 = STRING: "^L"

For this I adapted the code from:

            if not data:
                break

to

            if not data or data == "^L":
                break
  1. no matter if FIRMID is set to MAIN or SUB3 and the response for the query is:
<?xml version="1.0" encoding="UTF-8" ?><RESPONSEINFO><FIRMUPDATEINFO><VERSIONCHECK>2</VERSIONCHECK></FIRMUPDATEINFO></RESPONSEINFO>
sedrubal commented 1 year ago

Hi @darix thanks for sharing this. Would you mind opening a pull request?

sedrubal commented 9 months ago

I'll close this issue due to the lack of feedback. Feel free to reopen it as soon as you can provide more information that can be used for a fix.