Closed dlenski closed 4 months ago
For what it's worth, I'm using an old version of the tool, 332eb4f, because I'm on an old version of Python, but there don't seem to be any recent changes that would affect its ability to find the firmware for this printer… unless it needs some crazy hack akin to 565ef037ea8fd9ccc6bd0b03dd7c18120f7f17e6 :sweat_smile:
there don't seem to be any recent changes that would affect its ability to find the firmware for this printer… unless it needs some crazy hack akin to https://github.com/sedrubal/brother_printer_fwupd/commit/565ef037ea8fd9ccc6bd0b03dd7c18120f7f17e6 😅
Should've tested it first. Yes, indeed, the misspelling-based "fixes" from 565ef037ea8fd9ccc6bd0b03dd7c18120f7f17e6 / #19 do indeed resolve this, and allow me to update the firmware successfully. :dizzy_face:
Yes, indeed, the misspelling-based "fixes" from 565ef03 / #19 do indeed resolve this, and allow me to update the firmware successfully. 😵
Perhaps apply_mfc_l3750cdw_hack
deserves a more generic name now :sob:
Thanks for your report and for digging into it. I'll rename the function 😉 Is there a reason why you're stuck to an old version of Python? I think the minimum Python version is quite an arbitrary decision and we can support older versions again if required.
Is there a reason why you're stuck to an old version of Python?
Running an older Linux distribution (Ubuntu 20.04) and generally being a fan of the traditional Debian-based distros’ approach to packaging Python ("only install one copy of anything").
I think the minimum Python version is quite an arbitrary decision and we can support older versions again if required.
Cool! Adding some CI to verify that the code builds and runs with older versions would be a good way to get fast feedback on things that've broken older versions.
You can see how I do things in some of my Python projects with Github-CI, like https://github.com/dlenski/python-vipaccess/blob/master/.github/workflows/test_and_release.yml#L14
This printer identifies itself in a slightly strange way, as MODEL=
HL-L2360D series
:This leaves the tool unable to find its firmware:
If I override the MODEL value to simply
HL-L2360D
, or toHL-L2360DW
, it gets slightly further, but with an unexpected VERSIONCHECK=2:I know that newer versions of the firmware (1.36/1.12) exist thanks to https://support.brother.com/g/b/downloadlist.aspx?c=ca&lang=en&prod=hll2360dw_us&os=10068