In order for firmware uploading to work, download_fw needs to return the
path of the downloaded firmware file.
Use port 9100 as fallback default for firmware upload
In the case when the printer was not autodiscovered (e.g. IP address
specified explicitly with -p 192.168.1.234), the parameter port will be
None, and the intended default behavior will depend on the local system
database (e.g. /etc/protocols) having an entry for pdl-datastream.
Add port 9100 as the intended fallback port when this is missing.
[bug] Condition reversed in https://github.com/sedrubal/brother_printer_fwupd/pull/21/files#r1594590002
[bug] download_fw was broken
In order for firmware uploading to work,
download_fwneeds to return the path of the downloaded firmware file.Use port 9100 as fallback default for firmware upload
In the case when the printer was not autodiscovered (e.g. IP address specified explicitly with
-p 192.168.1.234), the parameterportwill beNone, and the intended default behavior will depend on the local system database (e.g./etc/protocols) having an entry forpdl-datastream.Add port 9100 as the intended fallback port when this is missing.
See https://github.com/sedrubal/brother_printer_fwupd/commit/831d9858#r141422105
Use type annotations in a way that remains compatible with Python 3.7+
This requires using
UnionandOptionalrather than|, and not using subscripted Python type objects. See discussion at https://github.com/sedrubal/brother_printer_fwupd/issues/20#issuecomment-2081262876.Make zeroconf dependency optional again
In 9ca66c7, I made the zeroconf dependency optional. In 670eb045, it was made obligatory again, perhaps by accident.