search

sedrubal / brother_printer_fwupd

Script to update the firmware of some Brother printers
https://pypi.org/project/brother_printer_fwupd/
GNU General Public License v3.0
30 stars 5 forks source link

Doc error #4

Closed sveyret closed 2 years ago

sveyret commented 2 years ago

Hi, Just to warn that in the README is written: pip install --user --upgrade brother-printer-fwupd while actually, the package is named with underscores, not dash. It should be: pip install --user --upgrade brother_printer_fwupd

By the way, it worked with my printer, although already up to date: DCP-9020CDW

sedrubal commented 2 years ago

Hi @sveyret, thanks for your report. Actually I'm not sure, why there are dashes in the package name, but I think I've copied that command from https://pypi.org/project/brother_printer_fwupd/, which automatically redirects to https://pypi.org/project/brother-printer-fwupd/ . I assume, it makes not difference?

I added the DCP-9020CDW with c42c1a4, thanks!

sveyret commented 2 years ago

Strangely, it now works, indeed, even if I use dashes. But this morning, I had an error message, saying it could not find appropriate package, until I used the underscores.

sveyret commented 2 years ago

And, by the way, thank you for this project!