sedwards2009 / extraterm

The swiss army chainsaw of terminal emulators
https://extraterm.org
MIT License
2.49k stars 116 forks source link

0.71.0: "Inject Bash/Fish Shell Integration" command crashes terminal #422

Open pmtk opened 1 year ago

pmtk commented 1 year ago

First of all: thanks for developing this! It looks really nice and I love the frames - helps getting head around mess with long outputs and many commands.

Problem: when running the command, terminal exits immediately. When started from another terminal it prints out log about missing command. Tested with Bash and Fish shells.

/home/pm/Downloads/extratermqt-0.71.0-linux-x64/main/dist/main.cjs:138922
        throw new Error(`Unable to find command '${commandName}' in extension '${extensionName}'.`);
              ^
Error: Unable to find command 'inject-shell-integration:injectFishIntegration' in extension 'inject-shell-integration'.
    at ExtensionManager.executeCommand (/home/pm/Downloads/extratermqt-0.71.0-linux-x64/main/dist/main.cjs:138922:15)
    at Object.func (/home/pm/Downloads/extratermqt-0.71.0-linux-x64/main/dist/main.cjs:140692:32)
    at /home/pm/Downloads/extratermqt-0.71.0-linux-x64/main/dist/main.cjs:115563:9
    at Array.forEach (<anonymous>)
    at doLaterTimeoutHandler (/home/pm/Downloads/extratermqt-0.71.0-linux-x64/main/dist/main.cjs:115561:15)
    at EventEmitter.<anonymous> (/home/pm/Downloads/extratermqt-0.71.0-linux-x64/main/dist/main.cjs:115540:9)
    at EventEmitter.emit (node:events:513:28)
    at EventEmitter.fn [as emit] (/home/pm/Downloads/extratermqt-0.71.0-linux-x64/node_modules/@nodegui/nodegui/dist/lib/utils/helpers.js:27:16)
    at logExceptions (/home/pm/Downloads/extratermqt-0.71.0-linux-x64/node_modules/@nodegui/nodegui/dist/lib/core/EventWidget.js:66:38)

Looking for "inject" in the archive - looks like it's missing?

$ rg inject
node_modules/@nodegui/qode/package.json
4:  "description": "Qode is a lightly modified fork of Node.js that allows injecting a third party event loop alongside Node's event loop. It is designed to be used together with `@nodegui/nodegui`",

node_modules/@nodegui/nodegui/dist/lib/core/WrapperCache.js
35:        addon_1.default.WrapperCache_injectCallback(this._objectDestroyedCallback.bind(this));

extensions/InjectShellIntegration/package.json
2:  "name": "inject-shell-integration",
4:  "description": "Command to inject the Extraterm shell integration directly into the current terminal tab.",
34:        "command": "inject-shell-integration:injectBashIntegration",
40:        "command": "inject-shell-integration:injectFishIntegration",
46:        "command": "inject-shell-integration:injectZshIntegration",

main/dist/main.cjs
103213:      "application/vnd.groove-injector": {

extensions/TLDRPages/data/pages/common/magento.md
18:- Update code and dependency injection configuration:

extensions/TLDRPages/data/pages/common/pipx.md
24:`pipx inject {{package}} {{dependency1 dependency2 ...}}`

extensions/TLDRPages/data/pages/common/sqlmap.md
3:> Detect and exploit SQL injection flaws.

Startup log:

qt.qpa.plugin: Could not find the Qt platform plugin "wayland" in ""
2023-05-04 08:24:47.024 INFO [MainConfig] Looking for application_paths.json at '/home/pm/Downloads/extratermqt-0.71.0-linux-x64/application_paths.json'
2023-05-04 08:24:47.027 INFO [ConfigDatabase #0] Reading user configuration from /home/pm/.config/extratermqt/extraterm.json
2023-05-04 08:24:47.027 WARN [ConfigDatabase #0] Unable to find config for key  general
2023-05-04 08:24:47.028 WARN [ConfigDatabase #0] Unable to find config for key  command_line_action
2023-05-04 08:24:47.028 WARN [ConfigDatabase #0] Unable to find config for key  session
2023-05-04 08:24:47.029 INFO [main #0] Recording logs to  /home/pm/.config/extratermqt/extraterm.log
2023-05-04 08:24:47.090 INFO [main #0] User extension directory is: /home/pm/.config/extratermqt/extensions
2023-05-04 08:24:47.091 INFO [ExtensionManager #0] Scanning '/home/pm/Downloads/extratermqt-0.71.0-linux-x64/extensions' for extensions.
2023-05-04 08:24:47.094 INFO [ExtensionManager #0] Read extension metadata from '/home/pm/Downloads/extratermqt-0.71.0-linux-x64/extensions/About'.
2023-05-04 08:24:47.096 INFO [ExtensionManager #0] Read extension metadata from '/home/pm/Downloads/extratermqt-0.71.0-linux-x64/extensions/Autocomplete'.
2023-05-04 08:24:47.096 INFO [ExtensionManager #0] Read extension metadata from '/home/pm/Downloads/extratermqt-0.71.0-linux-x64/extensions/Autolink'.
2023-05-04 08:24:47.097 INFO [ExtensionManager #0] Read extension metadata from '/home/pm/Downloads/extratermqt-0.71.0-linux-x64/extensions/Colorizer'.
2023-05-04 08:24:47.097 INFO [ExtensionManager #0] Read extension metadata from '/home/pm/Downloads/extratermqt-0.71.0-linux-x64/extensions/CommunityTerminalThemes'.
2023-05-04 08:24:47.098 INFO [ExtensionManager #0] Read extension metadata from '/home/pm/Downloads/extratermqt-0.71.0-linux-x64/extensions/CopyBlock'.
2023-05-04 08:24:47.099 INFO [ExtensionManager #0] Read extension metadata from '/home/pm/Downloads/extratermqt-0.71.0-linux-x64/extensions/CopyLink'.
2023-05-04 08:24:47.100 INFO [ExtensionManager #0] Read extension metadata from '/home/pm/Downloads/extratermqt-0.71.0-linux-x64/extensions/DefaultKeybindings'.
2023-05-04 08:24:47.100 INFO [ExtensionManager #0] Read extension metadata from '/home/pm/Downloads/extratermqt-0.71.0-linux-x64/extensions/DefaultTerminalTheme'.
2023-05-04 08:24:47.101 INFO [ExtensionManager #0] Read extension metadata from '/home/pm/Downloads/extratermqt-0.71.0-linux-x64/extensions/DirectoryCommands'.
2023-05-04 08:24:47.101 INFO [ExtensionManager #0] Read extension metadata from '/home/pm/Downloads/extratermqt-0.71.0-linux-x64/extensions/DownloadBlock'.
2023-05-04 08:24:47.102 INFO [ExtensionManager #0] Read extension metadata from '/home/pm/Downloads/extratermqt-0.71.0-linux-x64/extensions/Find'.
2023-05-04 08:24:47.103 INFO [ExtensionManager #0] Read extension metadata from '/home/pm/Downloads/extratermqt-0.71.0-linux-x64/extensions/ITermColorsTerminalThemeProvider'.
2023-05-04 08:24:47.104 INFO [ExtensionManager #0] Read extension metadata from '/home/pm/Downloads/extratermqt-0.71.0-linux-x64/extensions/ImageBlock'.
2023-05-04 08:24:47.105 INFO [ExtensionManager #0] Read extension metadata from '/home/pm/Downloads/extratermqt-0.71.0-linux-x64/extensions/InjectShellIntegration'.
2023-05-04 08:24:47.105 INFO [ExtensionManager #0] Read extension metadata from '/home/pm/Downloads/extratermqt-0.71.0-linux-x64/extensions/InsertEmoji'.
2023-05-04 08:24:47.108 INFO [ExtensionManager #0] Read extension metadata from '/home/pm/Downloads/extratermqt-0.71.0-linux-x64/extensions/InternalCommands'.
2023-05-04 08:24:47.109 INFO [ExtensionManager #0] Read extension metadata from '/home/pm/Downloads/extratermqt-0.71.0-linux-x64/extensions/OpenLink'.
2023-05-04 08:24:47.109 INFO [ExtensionManager #0] Read extension metadata from '/home/pm/Downloads/extratermqt-0.71.0-linux-x64/extensions/StyleGuide'.
2023-05-04 08:24:47.110 INFO [ExtensionManager #0] Read extension metadata from '/home/pm/Downloads/extratermqt-0.71.0-linux-x64/extensions/TLDRPages'.
2023-05-04 08:24:47.111 INFO [ExtensionManager #0] Read extension metadata from '/home/pm/Downloads/extratermqt-0.71.0-linux-x64/extensions/TerminalTitle'.
2023-05-04 08:24:47.111 INFO [ExtensionManager #0] Read extension metadata from '/home/pm/Downloads/extratermqt-0.71.0-linux-x64/extensions/Tips'.
2023-05-04 08:24:47.112 INFO [ExtensionManager #0] Read extension metadata from '/home/pm/Downloads/extratermqt-0.71.0-linux-x64/extensions/UnixSessionBackend'.
2023-05-04 08:24:47.112 INFO [ExtensionManager #0] Read extension metadata from '/home/pm/Downloads/extratermqt-0.71.0-linux-x64/extensions/UnixSessionEditor'.
2023-05-04 08:24:47.113 INFO [ExtensionManager #0] Read extension metadata from '/home/pm/Downloads/extratermqt-0.71.0-linux-x64/extensions/UpdateChecker'.
2023-05-04 08:24:47.113 INFO [ExtensionManager #0] Starting extension 'about'
2023-05-04 08:24:47.129 INFO [ExtensionManager #0] Starting extension 'autocomplete'
2023-05-04 08:24:47.131 INFO [ExtensionManager #0] Starting extension 'autolink'
2023-05-04 08:24:47.132 INFO [ExtensionManager #0] Starting extension 'colorizer'
2023-05-04 08:24:47.137 INFO [ExtensionManager #0] Starting extension 'community-terminal-themes'
2023-05-04 08:24:47.137 INFO [ExtensionManager #0] Starting extension 'copy-block'
2023-05-04 08:24:47.140 INFO [ExtensionManager #0] Starting extension 'copy-link'
2023-05-04 08:24:47.141 INFO [ExtensionManager #0] Starting extension 'default-keybindings'
2023-05-04 08:24:47.141 INFO [ExtensionManager #0] Starting extension 'default-terminal-theme'
2023-05-04 08:24:47.141 INFO [ExtensionManager #0] Starting extension 'directory-commands'
2023-05-04 08:24:47.142 INFO [ExtensionManager #0] Starting extension 'download-block'
2023-05-04 08:24:47.151 INFO [ExtensionManager #0] Starting extension 'find'
2023-05-04 08:24:47.155 INFO [ExtensionManager #0] Starting extension 'itermcolors-terminal-theme-provider'
2023-05-04 08:24:47.163 DEBUG [itermcolors-terminal-theme-provider] ITermColorTerminalThemeProvider activating
2023-05-04 08:24:47.163 INFO [ExtensionManager #0] Starting extension 'image-block'
2023-05-04 08:24:47.165 INFO [ExtensionManager #0] Starting extension 'inject-shell-integration'
2023-05-04 08:24:47.165 INFO [ExtensionManager #0] Starting extension 'insert-emoji'
2023-05-04 08:24:47.171 INFO [ExtensionManager #0] Starting extension 'internal-commands'
2023-05-04 08:24:47.171 INFO [ExtensionManager #0] Starting extension 'open-link'
2023-05-04 08:24:47.172 INFO [ExtensionManager #0] Starting extension 'styleguide'
2023-05-04 08:24:47.173 WARN [ExtensionManager #0] Unable to load /home/pm/Downloads/extratermqt-0.71.0-linux-x64/extensions/StyleGuide/dist/StyleGuideExtension.cjs. Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/home/pm/Downloads/extratermqt-0.71.0-linux-x64/extensions/StyleGuide/dist/StyleGuideExtension.cjs' imported from /home/pm/Downloads/extratermqt-0.71.0-linux-x64/main/dist/main.cjs
2023-05-04 08:24:47.173 INFO [ExtensionManager #0] Starting extension 'tldr-pages'
2023-05-04 08:24:47.174 INFO [ExtensionManager #0] Starting extension 'terminal-title'
2023-05-04 08:24:47.182 INFO [ExtensionManager #0] Starting extension 'tips'
2023-05-04 08:24:47.184 INFO [ExtensionManager #0] Starting extension 'unix-session-backend'
2023-05-04 08:24:47.201 INFO [ExtensionManager #0] Starting extension 'unix-session-editor'
2023-05-04 08:24:47.209 INFO [ExtensionManager #0] Starting extension 'update-checker'
2023-05-04 08:24:47.218 WARN [ConfigDatabase #0] Unable to find config for key  system
2023-05-04 08:24:47.261 INFO [LocalHttpServer #0] Local HTTP IPC server running on http://127.0.0.1:42097/7068aac768d1c8f3842e87b3e71dd6d8