sedyh / awesome-ebitengine

A curated list of awesome Ebitengine frameworks, libraries and software
Other
640 stars 29 forks source link

Add a stack machine library for Ebiten. #2

Closed PenguinCabinet closed 2 years ago

PenguinCabinet commented 2 years ago

Hello! Nice to meet you. This awesome list is good!

Summary

I am making the state and stack machine library for the game programming using Ebiten. It provides the state and stack machine for the game programming. If you don't mind, I'd like to add it to this awesome list.

sedyh commented 2 years ago

Hello, thanks for the suggestion.

Could you please make the following changes:

https://go.dev/doc/effective_go#names https://go.dev/doc/effective_go#commentary https://pkg.go.dev/about#adding-a-package https://github.com/golang-standards/project-layout

PenguinCabinet commented 2 years ago

Thank you for replying and telling me. I understood those. When I finish those changes,I am going to mention to you and open a PR.

PenguinCabinet commented 2 years ago

Hi.

Summary

sedyh commented 2 years ago

Hi, sorry for the long wait.

There are also small nuances with indents and spaces, gofmt and goimports will quickly solve them automatically. Also I think a good linter can very quickly suggest what can be done (like golangci-lint).

PenguinCabinet commented 2 years ago

Hi,thank you for your reviewing.

sedyh commented 2 years ago

Hello. Sorry to bother you, could you also fix the snake case in the readme and run it through gofmt as well?

Regarding individual constructors, in the examples, immediately after initialization, fields are set (screen sizes and the first scene). I think it’s still worth taking them out separately, it’s better to let the package deal with initialization itself, it will be easier to maintain later. https://web3.coach/golang-why-you-should-use-constructors

Everything else is ok, I'm ready to merge after the fix.

PenguinCabinet commented 2 years ago

Hi,No problem.Thank you for your teaching.

sedyh commented 2 years ago

Okay, the repository has been added to the list.

PenguinCabinet commented 2 years ago

Thank yooooooooooou for that you teach to me politely!!!!! I could add it to the list by your help!!