search

seebi / dircolors-solarized

This is a repository of themes for GNU ls (configured via GNU dircolors) that support Ethan Schoonover’s Solarized color scheme.
http://ethanschoonover.com/solarized
MIT License
2.84k stars 452 forks source link

ansi-universal and ansi-light show 0777 folders in bad color combination #73

Closed jonascj closed 7 years ago

jonascj commented 7 years ago

I'm changing between dark and light solarized theme in my terminal emulator (termite) and I wanted to change dircolors as well, but I've noticed that dircolors.ansi-light and dircolors.ansi-universal cause 0777 folders to be drawn in a bad color combination (blue on yellow). See these screenshots demonstrating the weird colors of universal and light, and the good colors of dark:

http://imgur.com/gallery/U0Kvz

Is that a fault on my end, or just an unfortunate color combination nobody has noticed before? After all 0777 folders are rare, and maybe few users use the light themes.

Please advise if you need more information about my setup. I can dump values of $LS_COLORS etc. if you need them.

The fact that it looks nice with the ansi-dark theme leads me to believe I have my terminal emulator colors configured correctly, and the right boldfont settings.

jonascj commented 7 years ago

I made a my suggested fix into a pull request (my first ever on github, let me know if I fucked something up): https://github.com/seebi/dircolors-solarized/pull/74

seebi commented 7 years ago

@jonascj pr is merged, thanks for the note ...