segfault when correcting gopro lens

[ksamak]

Problem with Gopro© lens correction: No problem building, or copying to right gimp folder. but when i open the window, and choose the gopro maker, there's no camera, or lens. But there's a focal length and aperture, so i click OK. then i can see on the command line that gimp-lensfun has segfaulted.

i'm on debian wheezy, gnome3. all versions standard wheezy versions. i'll try and start gdb to explore a little.

at commit a898ecd5492a8b6294fcfda684548345ffb0b0df: make: g++ -DDEBUG=0 -O3 -Wall -fopenmp -pthread -I/usr/include/gtk-2.0 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/cairo -I/usr/include/libpng12 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/lib/x86_64-linux-gnu/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/gimp-2.0 -I/usr/include/glib-2.0 -I/usr/lib/x8664-linux-gnu/glib-2.0/include -I/usr/include/ -c -o src/gimplensfun.o src/gimplensfun.cpp src/gimplensfun.cpp: In function ‘void query()’: src/gimplensfun.cpp:205:5: warning: deprecated conversion from string constant to ‘gchar* {aka char}’ [-Wwrite-strings] src/gimplensfun.cpp:205:5: warning: deprecated conversion from string constant to ‘gchar {aka char}’ [-Wwrite-strings] src/gimplensfun.cpp:205:5: warning: deprecated conversion from string constant to ‘gchar {aka char}’ [-Wwrite-strings] src/gimplensfun.cpp:205:5: warning: deprecated conversion from string constant to ‘gchar {aka char}’ [-Wwrite-strings] src/gimplensfun.cpp:205:5: warning: deprecated conversion from string constant to ‘gchar {aka char}’ [-Wwrite-strings] src/gimplensfun.cpp:205:5: warning: deprecated conversion from string constant to ‘gchar_ {aka char*}’ [-Wwrite-strings] g++ -o gimp-lensfun src/gimplensfun.o -lgimpui-2.0 -lgimpwidgets-2.0 -lgimpmodule-2.0 -lgimp-2.0 -lgimpmath-2.0 -lgimpconfig-2.0 -lgimpcolor-2.0 -lgimpbase-2.0 -lgtk-x11-2.0 -lgdk-x11-2.0 -latk-1.0 -lgio-2.0 -lpangoft2-1.0 -lpangocairo-1.0 -lgdk_pixbuf-2.0 -lcairo -lpango-1.0 -lfreetype -lfontconfig -lgobject-2.0 -lglib-2.0 -L/usr/lib/ -llensfun -lglib-2.0 -lexiv2 -lstdc++ -fopenmp

[seebk]

Can you please supply an example image? I tried some GoPRo HD2 images from the internet and they worked well for me...

[seebk]

Mhm... from you description I assume you use a GoPro which is not in the database. So camera or lens is not selected and undefined which may cause a crash. As a fast fix I have added a check in the main processing routine which just skips processing if values are not set. Can you please retry with current git head?

Optimal solution would have been to show an error message, but I could not find out how to display a message from the processing routine :/

[ksamak]

On Mon, Aug 11, 2014 at 12:40:53PM -0700, seebk wrote:

Mhm... from you description I assume you use a GoPro which is not in the database. So camera or lens is not selected and undefined which may cause a crash. As a fast fix I have added a check in the main processing routine which just skips processing if values are not set. Can you please retry with current git head?

Optimal solution would have been to show an error message, but I could not find out how to display a message from the processing routine :/

Hi, I'm using a gopro 3+. I re-tested the head, it doesn't crash anymore, so that's good, yet if i didn't have a terminal behind gimp, i wouldn't have seen the difference. Which is disturbing is that i could select another maker/camera/lens to (badly) correct the image, and successfully process the image, yet i cannot do it with the "available" gopro setting. do you do any kind of detection on the image? or is it solely on the

image's metadata?

ksamak

[seebk]

When the plugin starts, it tries to identify your camera, lens and other information from the EXIF data. If there is a matching lens and camera it will be show in the drop down boxes. If there is no match or not sufficient information available the drop down boxes are kept empty.

In your case the gopro 3+ is not selected, because it is simply not available in the database. So there is no profile selected which means that no processing is done.

[seebk]

This should now be fixed in the current release.