search

seebk / GIMP-Lensfun

GIMP plugin for correcting lens distortion using the lensfun library and database
http://seebk.github.io/GIMP-Lensfun/
GNU General Public License v3.0
45 stars 12 forks source link

Is there an updated Gimp-lensfun for Gimp 2.10.9 or newer versions, if so where is it? #26

Open phd21 opened 5 years ago

phd21 commented 5 years ago

Hi seebk,

Thank you for providing the "gimp-lensfun" plugin.

Is there an updated Gimp-lensfun for Gimp 2.10.9 or newer versions, if so where is it? If I try to use the gimp-lensfun plugin from 04-27-2018 that I found with any version of Gimp 2.10.9 beyond November of 2018, it will not work and I get a message stating that the lensfun plugin is outdated.

Is there any way to use the lensfun packages that are available in Linux repositories or by compiling and installing lensfun in Gimp v2.10.9 or newer versions? Perhaps you have a script or wrapper or something else that could compile or allow Gimp 2.10.9 and newer users to use the installed lensfun packages instead of or as the "gimp-lensfun" plugin?

FYI: My post to Gimp developers Request or bugfix - Gimp v2.10 please use lensfun packages already available rather than gimp-lensfun (#2876) · Issues · GNOME / GIMP · GitLab https://gitlab.gnome.org/GNOME/gimp/issues/2876#note_421444

Best regards, Phil (phd21)

seebk commented 5 years ago

Hi Phil,

you could try the 2.10 branch

https://github.com/seebk/GIMP-Lensfun/tree/gimp-2.10

Last time I tested in November it worked fine with Gimp 2.10. The only thing why it is not yet released is the fact that it only supports 8bit per pixel. It would need a little more adaptions to also work on higher bitdepth buffers.

phd21 commented 5 years ago

Hi seebk,

Thank you for replying quickly.

Ok, I just compiled the gimp-2.10 branch of gimp-lensfun plugin on my Linux KDE Neon (Ubuntu 18.04) and copied into my Gimp AppImage v2.10.9 from 12-27-2018 plugins folder and it still did not work and produced the same comment below. Do I need to also get a specific tag? Update: I just tried the "0.2.4-dev" tag as well and it would not work either. Yet, the Gimp AppImage from 11-08-2018 works fine with the older compiled gimp-lensfun file from 04-27-2016?

git clone -b gimp-2.10 https://github.com/seebk/GIMP-Lensfun.git git checkout 0.2.4-dev

Gimp AppImage v2.10.9 from 12-27-2018 with newly compile gimp-lensfun

Could not execute plug-in "gimp-lensfun" (/home/user69/.config/GIMP-AppImage/2.10/plug-ins/gimp-lensfun) because it uses an obsolete version of the plug-in protocol.

The Gimp AppImage from 11-08-2018 does not work with the newly compiled gimp-lensfun either, unless you checkout 0.2.4-dev, but does with the 04-27-2016 compiled gimp-lensfun plugin version.

Plug-in crashed: "gimp-lensfun" (/home/user69/.config/GIMP-AppImage/2.10/plug-ins/gimp-lensfun)

The dying plug-in may have messed up GIMP's internal state. You may want to save your images and restart GIMP to be on the safe side.

I understand that the new Gimp v2.10.x can use higher bit-depth images. I do not know as much as you do about that aspect of the lensfun packages.

If you know why we are getting these outdated "obsolete version" messages and can modify the "gimp-lensfun" package to overcome that, I will try it for you and let you know. I do not know if that is possible or not. And as you pointed out, if people are using higher bit-depth images, would the gimp-lensfun plugin work with those without being updated to handle the higher bit depths? Out of curiosity, do you know if the current lensfun packages handle the higher bit depths? I just quickly read the lensfun web page and I did not see any mention of bit depths?

Best regards, Phil (phd21)

FYI: when I installed lensfun from the Software Manager or Synaptic Package Manager (SPM) it is version 1 and is installed in /usr/share/lensfun/version_1

When I downloaded, compiled, and installed the newer version 2 of lensfun it shows up in /usr/local/share/lensfun/version_2

How does the system or applications that use lensfun know which version to use?

seebk commented 5 years ago

Sorry, I do not have time right now to debug in detail why it does not work with your AppImage version of GIMP. Last time I compiled the gimp-2.10 branch of Gimp-Lensfun with Debian Sid and the GIMP 2.10.6 and liblensfun 0.3.2 packages from the Debian repos it worked fine. Maybe something has changed between GIMP version 2.10.6 and the GIMP 2.10.9 that you are using....

BTW: Please either try the Gimp-Lensfun master branch or gimp-2.10 branch, all other tags or branches are outdated.

Out of curiosity, do you know if the current lensfun packages handle the higher bit depths? I just quickly read the lensfun web page and I did not see any mention of bit depths?

Yes, Lensfun itself supports various pixel formats beyond 8bit RGB.

seebk commented 5 years ago

Note: I just saw that GIMP 2.10.9 is a developer version and not yet released. So it would be recommended to go back to 2.10.8 and see if it works there...