search

seed-hypermedia / mintter

Mintter: an app for knowledge communities. Powered by the Hypermedia protocol.
https://mintter.com
Apache License 2.0
162 stars 11 forks source link

editor: added image resize functionality #1675

Closed iskaktoltay closed 7 months ago

iskaktoltay commented 8 months ago

Added image resize functionality in drafts and setting width of images in publications.

horacioh commented 7 months ago

@iskaktoltay looks great! I just pushed some style changes so the image will stay in the center all the time. The only thing I would add is to make the video also resize. do you think this is easy to add?

horacioh commented 7 months ago

also we need to respect the width in the publication view

iskaktoltay commented 7 months ago

also we need to respect the width in the publication view

I did add it to publication content

iskaktoltay commented 7 months ago

@iskaktoltay looks great! I just pushed some style changes so the image will stay in the center all the time. The only thing I would add is to make the video also resize. do you think this is easy to add?

I'm not sure because video embeds and uploaded videos use different components to display the video. I will take a look

horacioh commented 7 months ago

I did add it to publication content

yep I saw it after! I did change the styles so the image will be centered too!

nice work!

horacioh commented 7 months ago

I'm not sure because video embeds and uploaded videos use different components to display the video. I will take a look

I think this PR is ready to go, let's do Videos as a Nice to have if you can!