search

seed-hypermedia / seed

Seed Hypermedia Desktop app
Apache License 2.0
7 stars 1 forks source link

Make sure when focusing to a section of the document, the heading is not blocked by anything (newspaper header is blocking now) #52

Open SalvaZaraes opened 3 weeks ago

SalvaZaraes commented 3 weeks ago

Description: In the desktop app, the focus button (used to jump to a specific heading within a document) does not function as expected. Clicking it does not take the user to the designated heading.

Steps to Reproduce: Open a document in reading mode on the desktop app. Use the focus button to jump to a heading.

Expected Behavior: Clicking the focus button should scroll the view to the specified heading within the document.

ericvicenti commented 3 weeks ago

I just fixed this on desktop- the focus button has been disabled but the block is highlighted and scrolls when you click it

https://github.com/seed-hypermedia/seed/commit/4add0b5b16ff3ee5b3ed0b3a8c29e6bbe11075d3

@horacioh the one remaining problem is the scroll-to offset. If you have a newspaper header and you click on a short block from the outline, the block scrolls behind the header and can't be seen