search

seed-rs / seed-quickstart-webpack

Template for web apps with Seed (Rust framework), TailwindCSS and Webpack.
https://quickstart-webpack.seed-rs.org
Other
111 stars 13 forks source link

yarn start leads to TypeError #4

Open flosse opened 5 years ago

flosse commented 5 years ago

That's what I did:

git clone https://github.com/MartinKavik/seed-quickstart-webpack
cd seed-quickstart-webpack
yarn
yarn start

That's the error msg: Bildschirmfoto_2019-10-08_17-05-25

flosse commented 5 years ago

...the funny thing is, I try to move from JS/NPM to Rust just because of this kind of problems ;-)

MartinKavik commented 5 years ago

It seems that they were playing with fs.promises - https://github.com/jprichardson/node-fs-extra/issues/551#issuecomment-378322889.

And it's probably the reason why your promises are undefined - https://github.com/wasm-tool/wasm-pack-plugin/blob/872af9ec5f57837c2234a488a76a407ff227b40f/plugin.js#L120.

So it's possible that I (and CI) have a little bit different NodeJS version.. And you know the JS drill.. what's your NodeJS version and OS, please?

flosse commented 5 years ago

what's your NodeJS version and OS, please?

MartinKavik commented 5 years ago

Issue in wasm-pack-plugin: https://github.com/wasm-tool/wasm-pack-plugin/issues/69

Temporary workaround: Just copy https://raw.githubusercontent.com/wasm-tool/wasm-pack-plugin/2d74352d703526508e2de95d6b1cacbca1b2101f/plugin.js to /node_modules/@wasm-tool/wasm-pack-plugin/plugin.js

fattenap commented 4 years ago

This looks like it may have been resolved in the current version on wasm-pack-plugin@1.3.1

MartinKavik commented 4 years ago

This looks like it may have been resolved in the current version on wasm-pack-plugin@1.3.1

@fattenap Are you sure? My PR hasn't been merged to wasm-pack and the bug is specific to only some OSs and NodeJS versions - it's not super easy to reproduce it.

Also there is still wasm-pack-plugin v. 1.0.1 in our package.json because newer versions brake our CI (I don't remember the error).

fattenap commented 4 years ago

Oh, I didn't realise it was for specific Node versions. Reopening.