search

seed-rs / seed-rs.org

Seed's official website
https://seed-rs.org/
Other
14 stars 40 forks source link

Fixes #36 #37

Closed iahmed5 closed 4 years ago

MartinKavik commented 4 years ago

Why closed?

iahmed5 commented 4 years ago

Why closed?

PR failed some checks so just did it again.

MartinKavik commented 4 years ago

Some tips:

Thanks for fixes!

iahmed5 commented 4 years ago

Some tips:

  • Please use a more descriptive PR name and then you can write Fixes #XX in the description.
  • You don't have to close PRs - just push/force push the same branch and PRs will be automatically refreshed.
  • Make sure you have the latest Rust (rustup update) and then run cargo make verify in crate directory to make sure that all tests pass - the same tests and linters are executed on the CI pipeline.

Thanks for fixes!

Understood. Just a question about cargo make verify its seems to be invalid command as the terminal throws the following error.

image

I have tried cargo check command mentioned in Rust doc instead on my clone without making any changes and it returns the following error.

image

... rust update image

Is there something I am doing wrong?

MartinKavik commented 4 years ago

This repo is based on this template - https://github.com/seed-rs/seed-quickstart-webpack (link is also in the REAMDE in this repo). There should be everything that you need to resolve problems above in the README.

Basically you need to install cargo make (cargo install cargo-make) and classes are generated by Webpack so you need to run at least yarn generate:css_classes (https://github.com/seed-rs/seed-quickstart-webpack/blob/master/package.json#L10).