Closed platy closed 4 years ago
Thanks! Please run cargo make verify
in crate
folder to make sure everything is ok and push / force push. GitHub Actions are a little bit unstable these days so we cannot test and lint it on CI now.
I'm not sure whether this is the style that the project is going for.
Well, I'm happy that you fixed 0.6.0 docs, but there are many changes in incoming 0.7.0 so the style in 0.6.0 docs isn't very important I think. (However I'll take inspiration from it for writing 0.7.0 docs).
I'm just getting started with seed
Fetch (and other APIs) has been refactored and simplified in master
(aka future 0.7.0) - so I recommend to see e.g.
(master
and its examples are linted and tested so don't be afraid to use it - we'll update quickstarts and docs during the release.)
Thanks, I'll check out 0.7.0.
Is there another step before cargo make verify
? There is some missing generated code.
% cargo make verify
[cargo-make] INFO - cargo make 0.30.5
[cargo-make] INFO - Project: seed_rs_org
[cargo-make] INFO - Build File: Makefile.toml
[cargo-make] INFO - Task: verify
[cargo-make] INFO - Profile: development
[cargo-make] INFO - Running Task: fmt
[cargo-make] INFO - Execute Command: "rustup" "run" "nightly" "cargo" "fmt" "--all"
Error writing files: io error: Failed to find module css_classes in "/Users/mike/ws/seed-rs.org/crate/src/generated" None
[cargo-make] ERROR - Error while executing command, exit code: 1
[cargo-make] WARN - Build Failed.
Is there another step before cargo make verify
See https://github.com/seed-rs/seed-rs.org/blob/master/.github/workflows/main.yml#L36
But it looks like GitHub Actions work now and tests pass - merging - thanks!
The receiving data example wasn't compiling for several reasons, it now compiles against
seed = "^0.6.0"
.I'm just getting started with seed so I'm not sure whether this is the style that the project is going for.