search

seed-rs / seed

A Rust framework for creating web apps
MIT License
3.81k stars 155 forks source link

Have a working example with trunk #561

Closed seanybaggins closed 2 years ago

seanybaggins commented 3 years ago

Closes issue #535.

Created an example that uses trunk instead of the cargo make setup.

Some questions... Is it worth making or replacing examples to use trunk?

Things that should still be done... Update documentation for users to use trunk if that is a direction that is chosen.

MartinKavik commented 3 years ago

@seanybaggins Thanks for the PR!

Is it worth making or replacing examples to use trunk?

I would just modify the original examples and remove as much code as possible. Less code => less confusion, less bugs, better maintainability.

But there are three main blockers for Trunk integration:

  1. wasm-opt integration - https://github.com/thedodd/trunk/issues/5#issuecomment-682152671
  2. Clean previous build artifacts - https://github.com/thedodd/trunk/pull/69
  3. Resolve infinite watch & rebuild loop - https://github.com/thedodd/trunk/pull/84

We can live without automatic wasm-bindgen installation, auto-reloading etc., but these three things reduce developer experience and app quality significantly and I can't recommend to use it for production at the moment.

I unfortunately doesn't have a capacity to resolve those problems in the near future, so we would be glad for any help. Then we can continue with this PR. Does it make sense?

seanybaggins commented 3 years ago

Total sense. I will see if I can work on any of the issues you mentioned. Thanks for making Seed :)

flosse commented 2 years ago

I also like the idea of using trunk as a standard tool. Instead of creating an additional example, I would update the documentation and migrate all the examples. So I'm closing this topic now and linking it to #611.