search

seed-rs / seed

A Rust framework for creating web apps
MIT License
3.8k stars 153 forks source link

Seed 0.8 accepting the newest wasm-bindgen #698

Open wkordalski opened 2 years ago

wkordalski commented 2 years ago

Seed 0.8 extended Closure with new method via a trait, because this method was missing in wasm-bindgen < 0.2.81. wasm-bindgen 0.2.81 introduced Closure::new.

Thus Closure::new changed meaning from <Closure as ClosureNew>::new() to Closure::new leading to compilation errors. These errors were fixed in Seed 0.9 (probably f284711f3fc4a9deebf70c9f0ce4d8ec1daca36f). Could you backport this fix to Seed 0.8, so that apps using Seed 0.8 can be compiled correctly using the newest version of wasm-bindgen?

https://github.com/seed-rs/seed/issues/685 is blocking me from moving to Seed 0.9.

I can create pull request with backported fix if you want. Unfortunatelly I cannot publish it to crates.io.

flosse commented 2 years ago

I can create pull request with backported fix if you want.

that would be cool! :+1:

Unfortunatelly I cannot publish it to crates.io.

me too. Also #695 is blocked because no one has access to crates.io but @David-OConnor :disappointed:

wkordalski commented 2 years ago

I've backported the fix. You can find it here: https://github.com/wkordalski/seed/tree/0.8 I couldn't create PR, because PRs cannot create branches.

flosse commented 2 years ago

ok, here is the v0.8.x branch now: https://github.com/seed-rs/seed/tree/v0.8.x