search

seedcase-project / seedcase-sprout

Upload your research data to formally structure it for better, more reliable, and easier research.
https://sprout.seedcase-project.org/
MIT License
0 stars 0 forks source link

refactor: :sparkles: add frictionless-style sample data and metadata #530

Closed martonvago closed 1 month ago

martonvago commented 1 month ago

Description

This adds metadata for patients.csv using the frictionless standard. See the Notes section of this comment for some more context.

I put this in persistent_storage, imagining that we would eventually want a folder structure where data projects live in separate folders in some sort of secure storage space, with each project folder containing one datapackage.json metadata file and any number of data files. But I'm not super sure where to actually put the project folders.

We also have a very sensible rule to gitignore data in persistent_storage, which I overruled in this case to add the sample data. I'm also very open to any other ideas about how we should do this.

I haven't yet removed the old sample data, as it's still used by the database in app. I thought we could remove it when we switch over to the new sample data.

Closes #511

Reviewer Focus

This PR needs more of an in-depth review. Focus on the structure of the metadata and the folder structure.

Checklist

martonvago commented 1 month ago

I also removed custom properties, as discussed.