seedcase-project / seedcase-sprout

Upload your research data to formally structure it for better, more reliable, and easier research.
https://sprout.seedcase-project.org/
MIT License
0 stars 0 forks source link

feat: ✨ add `create_resource_structure()` #610

Closed signekb closed 2 weeks ago

signekb commented 2 weeks ago

Description

Bringing together the smaller functions to make an external facing function.

Closes #568

Relates to #533 (bc I have added a __init__.py in core with create_resource_structure())

Reviewer Focus

This PR needs an in-depth review.

Focus on:

  1. How do we want to import internal functions to user-facing functions like create_resource_structure()? This also relates to general refactoring; right now all core functions are in the same folder which will become messy as we add new functions. Thoughts at this point? Do we want to keep as is for now and then wait for a refactoring session later on?

Checklist

K-Beicher commented 2 weeks ago

Looks good, I'm a big fan of putting things away in folders, but I'm also of the opinion that sometimes it is best to wait a little, until you can see a pattern emerging and make folders based on that. So again - let's see what @lwjohnst86 has to say :-)

lwjohnst86 commented 2 weeks ago

@signekb and I am also of the similar opinion as the others. I think keeping them all in the same folder works for now and explicit importing of needed functions 👍🏻