search

seedcase-project / seedcase-sprout

Upload your research data to formally structure it for better, more reliable, and easier research.
https://sprout.seedcase-project.org/
MIT License
0 stars 0 forks source link

refactor: :recycle: rename "sprout" folder to "seedcase_sprout" #844

Closed signekb closed 2 weeks ago

signekb commented 2 weeks ago

Description

This PR renames the sprout folder to seedcase_sprout and fixes imports as a result of this renaming. It also renames the app in all Django settings and poetry/project configs.

Closes #813

This PR needs a quick review. There shouldn't be anything controversial going on here.

Checklist

signekb commented 2 weeks ago

@martonvago Welcome to what I have spend the day trying to figure out 😅 I think that it's something about how migrations work, that I just don't understand. But see #845 - we might just remove all Django-related things for now. As @lwjohnst86 also said: If we remove all old files that we don't use anymore, the repo will also just be a lot cleaner for when we publish to PyPi

Edit: Why it fails now is bc I have removed the Django setup steps from our test workflow here seedcase-project/.github#194 --- which makes all Django related tests fail (I hadn’t entirely thought that through). Before that, the workflow failed bc a table were missing all of a sudden (app.datatypes). And that had something to do with the migrations. I think that the old name sprout must be referenced somewhere in the migrations that I can't seem to find 🤷‍♀️

martonvago commented 2 weeks ago

@signekb Ohhhh, I can't say I'm jealous but 💪💪💪