seedhartha / reone

Game engine capable of running KotOR and TSL
GNU General Public License v3.0
271 stars 24 forks source link

Extract script updates #35

Closed wbrawner closed 3 years ago

seedhartha commented 3 years ago

So the original idea was:

  1. Directories: set in-script, choose via dialog if not found
  2. Steps: set default action in-script (third parameter in steps) , ask user if not set

But I guess that your variant is more conventional and does not require modifying the script. Can you remove these now-redundant options then? E.g.:

game_dir = os.getenv("REONE_GAME_DIR")
steps = [
    ["extract_bifs", "Extract BIF files (y/n)?"]
]
wbrawner commented 3 years ago

Yeah personally I think it's easier to not have to modify the script, as you then have to either tell git that it's unchanged or remember to never commit it, and of course if anyone ever makes any changes to the script that get committed, you have to rebase on top of it each time.

seedhartha commented 3 years ago

Merged, thanks!