search

seedvault-app / seedvault

A backup application for the Android Open Source Project.
1.19k stars 73 forks source link

Support installing via F-Droid Basic #595

Closed t-m-w closed 7 months ago

t-m-w commented 7 months ago

If an app being restored was unable to be installed from a backup, e.g. because it was missing, and the app was originally installed with F-Droid Basic, try to install it using F-Droid Basic again, as is done with other listed installers.

t-m-w commented 7 months ago

What this change doesn't try to do (and I haven't tested the behavior) is ensure that F-Droid Basic is actually available before reaching this point.

From discussion, if I'm understanding right, this only becomes relevant if some apps fail to be restored (or APK backup was turned off, so the APKs aren't available). It requires the user to tap to install the app, which uses the logic here to decide which installer app to launch.

This could be a potential problem for any of the installers, I think, though I'm not sure what if anything could be done about it, at least on the restoration side of Seedvault.

chirayudesai commented 7 months ago

This could be a potential problem for any of the installers, I think, though I'm not sure what if anything could be done about it, at least on the restoration side of Seedvault.

Yes I don't think we can solve it here. Anyone including SeedVault would have to solve it in however way they see fit - and there's multiple ways to do it.

Most we can do is show helpful error messages to the user.

grote commented 7 months ago

What this change doesn't try to do (and I haven't tested the behavior) is ensure that F-Droid Basic is actually available before reaching this point.

The way I am reading the code is that if the installer is not installed itself, we are are opening up the intent for other market:// intent handling apps to grab. So the user should see a chooser if more than one such app is available.