search

seedvault-app / seedvault

A backup application for the Android Open Source Project.
1.25k stars 74 forks source link

Better SetupWizard integration #63

Open chirayudesai opened 4 years ago

chirayudesai commented 4 years ago

This ticket intentionally has a vague sounding title.

We could allow the user to configure backups via the SetupWizard, that would be it's own thing. They would be prompted to select a storage location, and note down the 12-word code. So this would have to be after Wi-Fi setup, and also need the Nextcloud app (or any other storage provider offered by default for that matter) to be installed before being shown.

And at the same time, we could try and make the design and feel of the current restore screen match the SetupWizard as much as possible. This would be useful for a future backup screen too. It's nothing major, but I mean tiny things like making the "don't restore" and "next" button look more like they already do for other SetupWizard buttons texts. Another thing I noticed is that the restore screen is fully immersive which makes it look weird honestly speaking.

Minor nits like these are what make it look less like a SetupWIzard page and more like another app.

So

grote commented 4 years ago

Configure Backup from SetupWizard

This should probably be a ticket in the SetupWizard repo as well.

Make the restore screen's buttons more like SetupWizard

Or the other way around. Seedvault uses the normal colored material design buttons as the stock SetupWizard uses. See https://github.com/stevesoltys/seedvault/issues/34

Make the restore screen not fully immersive. Need to see the navbar and status bar.

Now resolved in https://github.com/grote/backup/commit/c52d3724426ae8b832dd5c4f5a937e5c44e9a58a can be checked.

grote commented 3 years ago

Configure Backup from SetupWizard

Google is showing a notification after setup (and periodically) that the phone doesn't get backed up, prompting the user to set up backup. This might be an alternative that doesn't keep the user writing down recovery codes during setup wizard.

chirayudesai commented 3 years ago

Configure Backup from SetupWizard

Google is showing a notification after setup (and periodically) that the phone doesn't get backed up, prompting the user to set up backup. This might be an alternative that doesn't keep the user writing down recovery codes during setup wizard.

That could work. Could show notification on first boot, and clear it when backup is setup.

chirayudesai commented 3 years ago
  • [x] Make the restore screen not fully immersive. Need to see the navbar and status bar.

I can't remember why it says navbar and status bar here, I guess I may have meant the in-app / suw nav bar rather than the system navbar.

Anyway, current / android10 behaviour is to hide the nav bar (but show the status bar), and that is correct, since then it looks like just another setupwizard page.

Current: https://github.com/stevesoltys/seedvault/pull/73 "Hide navigation bar in SetupWizard for more visual consistency"

grote commented 2 years ago

@chirayudesai can we check the second box now?