search

seegno / jscs-config-seegno

Seegno-flavored JSCS config
2 stars 0 forks source link

Add `should.js` as a peer dependency #27

Closed nunofgs closed 8 years ago

nunofgs commented 8 years ago

The require-should-assertion-execution rule requires should.js@8.x due to the assumptions it makes on the Assertion prototype object.

Please consider adding should.js as a peer dependency for other dependees.

Note, here is the cryptic error you'll receive if you have should.js < 8.x:

$ jscs src/
expected undefined to be true

See https://github.com/seegno/sql-tag/pull/2 for more information.

ruiquelhas commented 8 years ago

We are dropping this preset.