Error in example: "Create and commit a new transaction"

seegno / uphold-sdk-php

Uphold PHP SDK

http://seegno.com

28 stars 24 forks source link

Error in example: "Create and commit a new transaction" #100

Closed zekylaf closed 8 years ago

zekylaf commented 8 years ago

Hi, in Readme says getCardsById('ade869d8-7913-4f67-bb4d-72719f0a2be0'); but I think that it would say getCardById('ade869d8-7913-4f67-bb4d-72719f0a2be0'); (no s in getCardById).

It would be useful to add the possibility to get a card using its address too.

nunorafaelrocha commented 8 years ago

Hi @zekylaf, Well spotted, I've created a pull request #101 to fix that typo.

About that getCardByAddress, I've created a new issue #102 to discuss this issue.