search

seegno / uphold-sdk-php

Uphold PHP SDK
http://seegno.com
28 stars 24 forks source link

updating symfony/console to 3.2 #152

Closed bigdawggi closed 6 years ago

bigdawggi commented 6 years ago

Hi there, thanks for writing the Uphold SDK! I notice that to use the SDK with Laravel 5.5.x it's requiring that I update your libraries requirement for symfony/console from ~2.6 to ~3.2.8 (looks like it could be any ~3.0 version, but not tested). I haven't noticed issues running your client with this later version of symfony/console and wonder about getting a pull request moving along to get that console requirement updated.

Any thoughts on your end about doing this?

bigdawggi commented 6 years ago

hmmm, trying to run phpunit, and can't because composer install tries to install phpdocumentor and that requires symfony/console ~2.3 (so, if I understand correctly, that would go through 2.9.x, but not up to 3.x). So unless we want to drop the phpdocumentor dependency, we're likely not going up to symfony/console 3.x.

bigdawggi commented 6 years ago

I went ahead and changed the symfony/console requirement to be ~3.2 instead of ~3.2.8. More what I was meaning ;)

nunorafaelrocha commented 6 years ago

Hi @bigdawggi, thanks for the pull request. We’ve a lot on our plate. Allow us some time to review and merge this. Thanks