rurban
commented
4 years ago Ad 2) you set CFLAGS in configure.ac. Not to used to autoconf, but I'd presume that's generally not a good way to achieve portability, as it stands to overwrite user settings
Nope, I add to CFLAGS, and don't want to set AM_CFLAGS. Later I will probe for the best CFLAGS (via autoconf-archive macros), but for now I went with this mess. More important is to get it modern first. See https://github.com/rurban/dieharder/issues/1
I'll rather just close this PR and discuss it with upstream. I dont think Jochen wants to maintain it anyway.
Ad the xoroshiro fails: Could be the fast double-conversion. I used Vigna's recommended variant. Which is different to the dieharder conversion by divsion. Also could be the seeding. I tried a good seed, better than Vigna's {1,-1, 0, 0} default seed. But I rather think it's just trash.