search

seeing-things / zwo

ZWO SDK and custom software for debugging and using it.
23 stars 4 forks source link

Crosshairs appearing in some frames written to disk #63

Closed bgottula closed 3 years ago

bgottula commented 3 years ago

I captured imagery using ad4ecb3888e1d09844a27b9db9e099285cbc29eb this evening and I found that some frames in the SER file had grey crosshairs appearing on them. In several cases I inspected the vertical line was not drawn all the way to the top of the frame, suggesting that perhaps the code modifying the frame with this crosshair annotation was not finished performing this operation while the frame was being written to disk.

If it is possible to fix the crosshair feature such that it does not alter the frames being written to disk without incurring a significant performance hit, then do so. Otherwise remove the crosshairs feature.

bgottula commented 3 years ago

I realized this issue was specific to the mono ASI178MM camera. For color cameras, the debayering step makes a new copy of the frame to which the crosshairs are applied. For mono cameras debayering is not necessary and the copy step was thus omitted, thus the crosshairs annotation was being applied to the shared original frame buffer.