search

seek-oss / capsize

Flipping how we define typography in CSS.
https://seek-oss.github.io/capsize/
MIT License
1.51k stars 37 forks source link

Please add support for M PLUS Rounded 1c from Google Fonts #189

Closed mwawrusch closed 5 months ago

mwawrusch commented 5 months ago

Getting some warnings for the font M PLUS Rounded 1c in 14.2.0. See this thread in next: https://github.com/vercel/next.js/issues/47115#issuecomment-2051755660

import { M_PLUS_Rounded_1c } from "next/font/google";

Would be amazing if you could add this font. Thank you

michaeltaranto commented 5 months ago

Will do mate.

Have been focused on getting weight and variant support and haven't updated Google Fonts.

I'll resolve/close this issue when it's done.

mwawrusch commented 5 months ago

Thank you, much appreciated.

michaeltaranto commented 5 months ago

Bit of a deep dive. Ended up not related to our Google Fonts being behind, but rather that this particular font uses a different name for itself in its internal metrics, resulting in the module path not being as predictable as we'd like: @capsizecss/metrics/roundedMplus1c.

Made a change on our side to ensure our module paths always match the font name used by Google Fonts (rather than the internal metrics).

Given this changes the module path for about 20 fonts, we are treating it as a breaking change, but likely wont affect many.