search

seek-oss / playroom

Design with JSX, powered by your own component library.
MIT License
4.45k stars 183 forks source link

Crashes on chrome on iPad OS 14+ #208

Closed tamoore closed 3 years ago

tamoore commented 3 years ago

I was browsing the braid documentation today on my iPad Pro (so it should be able to computationally handle most things) and when I opened playroom from the documentation it crashed the website in incognito. See screenshot:

0A365E0E-5F4C-44A3-BCCA-2DDD1B712ADC

I tried it in normal mode (cookies enabled) and it was a bit better but for some reason the previews didn’t work:

6D181783-0442-467B-BB8E-2EB62D6D1B8D

No extensions were enabled.

michaeltaranto commented 3 years ago

Hey Todd 👋

I have checked it out on Safari desktop and in the iOS simulator and cant replicate. My initial thought was local storage access in private mode, but doesnt seem to be breaking for me, any difference in Safari for you?

tamoore commented 3 years ago

It might just be my device then but it’s the same in safari:

9263EC15-D50B-465D-89CB-DAD8E27A6AE4

michaeltaranto commented 3 years ago

To clarify, what do you mean by preview not working?

Might see if i can steal my wifes ipad to test it out on a real device 😄

tamoore commented 3 years ago

I tried adding some components and it works on both chrome and safari, so it was just the empty state that was confusing me.

It’s broken on incognito but that seems to be something you’d expect if it saves a cookie of any sort.

Can close it you want, as it seems to work, probably user error. 😀

On Wed, 16 Dec 2020 at 2:35 pm, Michael Taranto notifications@github.com wrote:

To clarify, what do you mean by preview not working?

Might see if i can steal my wifes ipad to test it out on a real device 😄

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/seek-oss/playroom/issues/208#issuecomment-745742161, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC2NPJJGDGIABFLO3AUCJPDSVATGJANCNFSM4U5HUDHQ .

michaeltaranto commented 3 years ago

Yeah there are preferences around themes, viewports and code that are stored in localStorage. So first thought was private browsing not being able to access storage, but that wouldn't be inconsistent, it would just flat out blow up if there was a problem.

All good, if you are happy that you cant reproduce reliably, let's close this.