search

seek-oss / playroom

Design with JSX, powered by your own component library.
MIT License
4.45k stars 183 forks source link

Update logo for GitHub darkmode #213

Closed ScopeyNZ closed 2 years ago

ScopeyNZ commented 3 years ago

The logo on the readme can't be read when GitHub is in dark mode:

image

michaeltaranto commented 3 years ago

Yeah i feel you on this one, i had a quick look a while ago, are you aware if there is any way to flip logo image based on colour mode? I couldnt find anything last time.

ScopeyNZ commented 3 years ago

You know, it's pretty coincidental that we've just been battling this issue with our own repos when I stumbled across one of @markdalgleish's talks that brought me here.

We've not been able to get it to work with fill="currentColor", and while we can get it to work with the browser dark mode APIs, that reflects your system settings, not GitHub's setting.

We've just gone to using a backgrounds again like back in 2000 🤷

michaeltaranto commented 3 years ago

I tried a bunch of things, currentColor, relying on cascading styles (trying to at least to get it working on web, but still failed), even tried nested documents using the css in readme hacks, still nothing.

maraisr commented 3 years ago

One compromise I have made for this, is to give the logo a stroke; see https://github.com/maraisr/diary @ScopeyNZ

ScopeyNZ commented 3 years ago

Thanks for the suggestion. We did consider this with our repos but a stroke doesn't really work with our brand unfortunately :(

maraisr commented 3 years ago

Ya, doesnt always work. But was a compromise. xstate got a tad funky with its as well.

Also worth mentioning the iOS app, readme background colour isnt the same as the website. So the stroke isnt bullet proof either.

ScopeyNZ commented 3 years ago

🙉